refactor makefile: var to inject adoc options; change to build dir instead of outfiles #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild dir instead of outfile Signed-off-by: Kevin Broch <[email protected]>
|
@wmat we will need to revert it. This broke the PDF generation process. |
|
Ok go ahead. I can look at it tomorrow.
Bill Traynor
Documentation Build and Release Engineer
RISC-V International
…On Fri, Jan 26, 2024 at 8:36 PM Rafael Sene ***@***.***> wrote:
@wmat <https://github.com/wmat> we will need to revert it. This broke the
PDF generation process.
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN6ZCOVNJCSMMZB2QW3FLYQRK2VAVCNFSM6AAAAABCIDSHF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSHEYDEOJZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@wmat in fact, we need to review all the commits from the last week. There was a lot of changes and I'm not sure which broke the process. |
kbroch-rivosinc
added a commit
to kbroch-rivosinc/docs-spec-template
that referenced
this pull request
Jan 27, 2024
relates to riscv#30 Signed-off-by: Kevin Broch <[email protected]>
I think the only problem might be that I didn't tell the action the new location of the pdf. I corrected this with PR #31 I didn't change the action to fail if it doesn't find a pdf. |
|
@kbroch-rivosinc I had to force and push the fix given the necessity to use the template for a new spec. Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.